Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Allow running microsoft queries from an azure asset #2201

Closed
wants to merge 1 commit into from

Conversation

preslavgerchev
Copy link
Contributor

@preslavgerchev preslavgerchev commented Oct 13, 2023

Assume we can get no credentials if running just shell azure. This also enables shell ms365 --tenant-id <value> which makes querying a bit easier

@preslavgerchev
Copy link
Contributor Author

Note: this currently doesn't work cause of #2196, I tested by dropping this commit and then re-building cnquery

@vjeffrey
Copy link
Contributor

we need to do the cross provider connection types stuff so we can include this

@vjeffrey
Copy link
Contributor

vjeffrey commented Oct 25, 2023

we need to add the cross provider types and then read those where we're doing that provider check, only allow cross provider when its explicitly defined in the config
https://github.com/mondoohq/cnquery/blob/main/providers/network/config/config.go#L16
https://github.com/mondoohq/cnquery/blob/main/providers/runtime.go#L578

@tas50 tas50 changed the title 🧹 Allow running microsoft queries from an azure asset. 🧹 Allow running microsoft queries from an azure asset Oct 27, 2023
@arlimus
Copy link
Member

arlimus commented Nov 6, 2023

I'll get the cross-provider mechanism rolling to tackle this.

@preslavgerchev
Copy link
Contributor Author

Closing this as the auth files have been moved, the fix in this PR is no longer applicable

@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants