🐛 Load provider flags from environment variables #4847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows `cnquery` to load all provider flags via environment variables. For instance, if a provider exposes a flag named `foo`, the user can export the environment variable `MONDOO_FOO` to provide a value. The trick here was to switch loading the flag values from `cobra` to `viper`, since we already ran `viper.BindPFlag()` inside the command `PreRun`, we can now use `viper.Get()` directly. Signed-off-by: Salim Afiune Maya <[email protected]>
afiune
force-pushed
the
afiune/load-providers-flag-via-viper-config
branch
from
78f0767
to
dd3bcd5
Compare
chris-rock
reviewed
Nov 13, 2024
| switch flag.Type { | ||
| case plugin.FlagType_Bool: | ||
| v, err := cmd.Flags().GetBool(flag.Long) |
There was a problem hiding this comment.
Do we need a bind equivalent somewhere? Like in https://github.com/mondoohq/cnspec/blob/main/apps/cnspec/cmd/scan.go#L105
There was a problem hiding this comment.
We already have it for all flags inside a provider. Though you're pointing to cnspec code so I'm assuming you want to know if this will work there. I can test, but this is working for cnquery.
There was a problem hiding this comment.
chris-rock
approved these changes
Nov 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows
cnqueryto load all provider flags via environment variables. For instance, if a provider exposes a flag namedfoo, the user can export the environment variableMONDOO_FOOto provide a value.The trick here was to switch loading the flag values from
cobratoviper, since we already ranviper.BindPFlag()inside the commandPreRun, we can now useviper.Get()directly.