Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ experimental: Add policy migrations to bundles #1461

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Oct 28, 2024

This contains their metadata only, not surrounding functionality at this point. It gives us a container to store migrations between versions of policies and collections, to retain information about what was added, or removed, or just modified (eg UIDs changing between versions).

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Test Results

  1 files  ±0   25 suites  ±0   19s ⏱️ ±0s
438 tests ±0  437 ✅ ±0  1 💤 ±0  0 ❌ ±0 
439 runs  ±0  438 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit c25daee. ± Comparison against base commit c7b62fd.

♻️ This comment has been updated with latest results.

@arlimus
Copy link
Member Author

arlimus commented Oct 30, 2024

@preslavgerchev This change sets up initial migration structure and enforces a few changes from my earlier design. It is necessary for some of the other work we are doing behind the scenes.

MODIFY = 3;
}

MigrationMatch match = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whats the match for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the conditions on which a check is matched for a migration. Imagine throwing all checks at a migration, when this condition is true (i.e. when it matches) then the appropriate action is run.

@arlimus arlimus merged commit b730fda into main Nov 4, 2024
14 checks passed
@arlimus arlimus deleted the dom/policy-migrations branch November 4, 2024 22:54
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants