Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧹 Support controls implemented by controls #676

Merged
merged 1 commit into from
Aug 3, 2023
Merged

🧹 Support controls implemented by controls #676

merged 1 commit into from
Aug 3, 2023

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Aug 2, 2023 •
edited
Loading

rp

@jaym jaym closed this Aug 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
@jaym jaym reopened this Aug 2, 2023
vjeffrey
vjeffrey approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@vjeffrey vjeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i haven't been as deep into this code as y'all have, but 👍 everything here looks sensible, thank you @jaym

@vjeffrey vjeffrey merged commit 148a636 into main Aug 3, 2023
7 checks passed
@vjeffrey vjeffrey deleted the jdm/control-control branch August 3, 2023 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vjeffrey vjeffrey vjeffrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaym @vjeffrey