Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: dynamic span, to calculate span limit dynamically #9495

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

src: dynamic span, to calculate span limit dynamically #9495

wants to merge 1 commit into from

Conversation

0xFFFC0000
Copy link
Collaborator

No description provided.

sneurlax
sneurlax reviewed Sep 30, 2024
View reviewed changes
src/cryptonote_protocol/cryptonote_protocol_handler.inl Outdated
@@ -62,7 +62,8 @@
#define MLOG_PEER_STATE(x) \
MCINFO(MONERO_DEFAULT_LOG_CATEGORY, context << "[" << epee::string_tools::to_string_hex(context.m_pruning_seed) << "] state: " << x << " in state " << cryptonote::get_protocol_state_string(context.m_state))

#define BLOCK_QUEUE_NSPANS_THRESHOLD 10 // chunks of N blocks
#define BLOCK_QUEUE_NSPANS_THRESHOLD 200 // chunks of N blocks
#define BLOCK_QUEUE_NSPANS_MINIMUM 10 // minimum number of spans //
Copy link
Contributor

@sneurlax sneurlax Sep 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dangling // is the only (non-)issue I see in this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for mentioning it. Fixed.

sneurlax
sneurlax approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@sneurlax sneurlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, straightforward changes.

@0xFFFC0000 0xFFFC0000 mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneurlax sneurlax sneurlax approved these changes

Assignees
No one assigned
Labels
daemon feature pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xFFFC0000 @sneurlax