Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

depends: remove option from toolchain file #9501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

depends: remove option from toolchain file #9501

wants to merge 1 commit into from

Conversation

tobtoht
Copy link
Contributor

@tobtoht tobtoht commented Oct 4, 2024

option doesn't belong in a toolchain file. These options exist, and are documented in, the (root) CMakeLists.txt. All variables here are overridden later on in the toolchain file.

0xFFFC0000
0xFFFC0000 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@0xFFFC0000 0xFFFC0000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks you. Having BUILD_TESTS in toolchain was always a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneurlax sneurlax sneurlax approved these changes

@0xFFFC0000 0xFFFC0000 0xFFFC0000 approved these changes

Assignees
No one assigned
Labels
build system enhancement pending review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobtoht @sneurlax @0xFFFC0000