-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-36195: Update Billing page with custom error function info #673
Merged
cbullinger
merged 3 commits into
mongodb:eventbridge-error-handling
from
cbullinger:docsp-36195-eventbridge-billing
Feb 14, 2024
Merged
DOCSP-36195: Update Billing page with custom error function info #673
cbullinger
merged 3 commits into
mongodb:eventbridge-error-handling
from
cbullinger:docsp-36195-eventbridge-billing
Feb 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindseymoore
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
tcannon91
reviewed
Feb 14, 2024
Co-authored-by: Taylor Cannon <[email protected]>
tcannon91
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
c16d66b
into
mongodb:eventbridge-error-handling
4 checks passed
lindseymoore
added a commit
that referenced
this pull request
Feb 22, 2024
* DOCSP-36195: Update Billing page with custom error function info (#673) * Update Billing page with custom error function info * Update source/billing.txt Co-authored-by: Taylor Cannon <[email protected]> * Formatting fix to make snooty happy --------- Co-authored-by: Taylor Cannon <[email protected]> * DOCSP-36191: Update Log pages with new Event Handler log type (#672) * Update Log pages with new Event Handler log type * Update Error Handler Logs page with correct fields * Use 'error handler' instead of 'error function' where possible * Update log forwarding UI image * Minor edit * Update source/logs/error-handler.txt Co-authored-by: Taylor Cannon <[email protected]> * Update to trigger_error_handler type * Update API log endpoints * Update UI images --------- Co-authored-by: Taylor Cannon <[email protected]> * DOCSP-36193: Update Admin API Trigger endpoints with EventBridge error handler properties (#675) * Update Admin API Trigger endpoints with EventBridge error handler properties * Update source/openapi-admin-v3.yaml Co-authored-by: Taylor Cannon <[email protected]> * Apply feedback --------- Co-authored-by: Taylor Cannon <[email protected]> * DOCSP-36192 Update Trigger Config for EventBridge Error Handling (#676) * DOCSP-36192 Update Trigger Config for EventBridge Error Handling * change heading style, add meta * review comments * formatting * review comments * linking with ref * retry code example format * update ref that will work once larger PR is merged * DOCSP-36189 Add custom error handling for triggers with AWS EventBridge (#674) * DOCSP-36189 Add custom error handling for triggers with AWS EventBridge * fast fixes * add logs section and small fixes * fix logs tabs * fix logs tabs v2 * fix logs procedure * add optimization, parameters section, update cli procedure * structurual review comments * fix formatting * formatting * more review comments * add 2 admin api sections * small typo * last internal review comments * fix ref links * delete diagram and fix formatting * fix programming lang tag * DOCSP-36194 Update CLI logs list with trigger_error_handler type (#678) --------- Co-authored-by: cbullinger <[email protected]> Co-authored-by: Taylor Cannon <[email protected]>
MongoCaleb
pushed a commit
to MongoCaleb/docs-app-services
that referenced
this pull request
Jun 3, 2024
* DOCSP-36195: Update Billing page with custom error function info (mongodb#673) * Update Billing page with custom error function info * Update source/billing.txt Co-authored-by: Taylor Cannon <[email protected]> * Formatting fix to make snooty happy --------- Co-authored-by: Taylor Cannon <[email protected]> * DOCSP-36191: Update Log pages with new Event Handler log type (mongodb#672) * Update Log pages with new Event Handler log type * Update Error Handler Logs page with correct fields * Use 'error handler' instead of 'error function' where possible * Update log forwarding UI image * Minor edit * Update source/logs/error-handler.txt Co-authored-by: Taylor Cannon <[email protected]> * Update to trigger_error_handler type * Update API log endpoints * Update UI images --------- Co-authored-by: Taylor Cannon <[email protected]> * DOCSP-36193: Update Admin API Trigger endpoints with EventBridge error handler properties (mongodb#675) * Update Admin API Trigger endpoints with EventBridge error handler properties * Update source/openapi-admin-v3.yaml Co-authored-by: Taylor Cannon <[email protected]> * Apply feedback --------- Co-authored-by: Taylor Cannon <[email protected]> * DOCSP-36192 Update Trigger Config for EventBridge Error Handling (mongodb#676) * DOCSP-36192 Update Trigger Config for EventBridge Error Handling * change heading style, add meta * review comments * formatting * review comments * linking with ref * retry code example format * update ref that will work once larger PR is merged * DOCSP-36189 Add custom error handling for triggers with AWS EventBridge (mongodb#674) * DOCSP-36189 Add custom error handling for triggers with AWS EventBridge * fast fixes * add logs section and small fixes * fix logs tabs * fix logs tabs v2 * fix logs procedure * add optimization, parameters section, update cli procedure * structurual review comments * fix formatting * formatting * more review comments * add 2 admin api sections * small typo * last internal review comments * fix ref links * delete diagram and fix formatting * fix programming lang tag * DOCSP-36194 Update CLI logs list with trigger_error_handler type (mongodb#678) --------- Co-authored-by: cbullinger <[email protected]> Co-authored-by: Taylor Cannon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Info
Jira ticket: https://jira.mongodb.org/browse/DOCSP-36195
Reminder Checklist
Before merging your PR, make sure to check a few things.
Release Notes
Review Guidelines
REVIEWING.md