Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-29501-time-series #158

Open
wants to merge 14 commits into
base: v1.8
Choose a base branch
from

Conversation

jason-price-mongodb
Copy link
Collaborator

@jason-price-mongodb jason-price-mongodb commented Sep 13, 2023

Time series behavior changes.

The JIRA has a linked document that states the addition of a new parameter named timeSeriesHandling. Per a discussion with the developer, timeSeriesHandling is for TSEs only and should not be doc'ed. The text has been briefly examined by the developer already for accuracy.

JIRA

https://jira.mongodb.org/browse/DOCSP-29501

Staging

https://docs-mongodbcom-staging.corp.mongodb.com/cluster-sync/docsworker-xlarge/DOCSP-29501-time-series/release-notes/1.7/#time-series-collections

https://docs-mongodbcom-staging.corp.mongodb.com/cluster-sync/docsworker-xlarge/DOCSP-29501-time-series/reference/limitations/#unsupported-collection-types

Copy link
Collaborator

@jmd-mongo jmd-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, @jason-price-mongodb! This one LGTM mod a nit.

Thank you,
Joe

source/reference/limitations.txt Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@jason-price-mongodb jason-price-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmd-mongo Done.

source/reference/limitations.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that the timeSeriesHandling question seems not to want to go away …

source/release-notes/1.7.txt Outdated Show resolved Hide resolved
@jason-price-mongodb
Copy link
Collaborator Author

@FGasper @ajayvijayakumar123 please re-review. Thanks.

Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mdb-ashley mdb-ashley deleted the branch mongodb:v1.8 November 7, 2023 15:11
@mdb-ashley mdb-ashley closed this Nov 7, 2023
@jason-price-mongodb
Copy link
Collaborator Author

@FGasper @ajayvijayakumar123 please re-review. Thanks!

@ajayvijayakumar123
Copy link
Collaborator

I think one of the staging links points to 1.7 release notes instead of 1.8. I'll defer the review to Felipe!

Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note about time-series handling in 1.7 and before.

Copy link
Collaborator Author

@jason-price-mongodb jason-price-mongodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FGasper please re-review. Thanks.

source/reference/limitations.txt Outdated Show resolved Hide resolved
source/reference/limitations.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@FGasper FGasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jason-price-mongodb
Copy link
Collaborator Author

@ajayvijayakumar123 please can you also confirm your LGTM and be sure to click the approve button.

Copy link
Collaborator

@ajayvijayakumar123 ajayvijayakumar123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants