-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-29501-time-series #158
base: v1.8
Are you sure you want to change the base?
DOCSP-29501-time-series #158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these updates, @jason-price-mongodb! This one LGTM mod a nit.
Thank you,
Joe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmd-mongo Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that the timeSeriesHandling
question seems not to want to go away …
@FGasper @ajayvijayakumar123 please re-review. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
1fdd98e
to
8a4ca3e
Compare
@FGasper @ajayvijayakumar123 please re-review. Thanks! |
I think one of the staging links points to 1.7 release notes instead of 1.8. I'll defer the review to Felipe! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note about time-series handling in 1.7 and before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FGasper please re-review. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@ajayvijayakumar123 please can you also confirm your LGTM and be sure to click the approve button. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Time series behavior changes.
The JIRA has a linked document that states the addition of a new parameter named timeSeriesHandling. Per a discussion with the developer, timeSeriesHandling is for TSEs only and should not be doc'ed. The text has been briefly examined by the developer already for accuracy.
JIRA
https://jira.mongodb.org/browse/DOCSP-29501
Staging
https://docs-mongodbcom-staging.corp.mongodb.com/cluster-sync/docsworker-xlarge/DOCSP-29501-time-series/release-notes/1.7/#time-series-collections
https://docs-mongodbcom-staging.corp.mongodb.com/cluster-sync/docsworker-xlarge/DOCSP-29501-time-series/reference/limitations/#unsupported-collection-types