-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-35856 - fastapi generator #945
DOCSP-35856 - fastapi generator #945
Conversation
source/python-drivers.txt
Outdated
------------------ | ||
|
||
- The `Full Stack FastAPI Generator <http://www.mongodb.com/blog/post/introducing-full-stack-fast-api-app-generator-for-python-developers>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This structure is modeled on the PHP page, as recommended in the ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we say "Full Stack FastAPI MongoDB App Generator"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, do we want to direct users to this url rather than the blog post? https://github.com/mongodb-labs/full-stack-fastapi-mongodb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense to me. I originally linked to the blog post because it contains a link to the repo, but linking directly to the repo seems more consistent with the rest of our docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a discussion point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-35856
Staging - https://preview-mongodbmongokart.gatsbyjs.io/drivers/docsp-35856-generator-note/python-drivers/#tools-and-projects
Self-Review Checklist