Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-35856 - fastapi generator #945

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

mongoKart
Copy link
Contributor

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-35856
Staging - https://preview-mongodbmongokart.gatsbyjs.io/drivers/docsp-35856-generator-note/python-drivers/#tools-and-projects

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

------------------

- The `Full Stack FastAPI Generator <http://www.mongodb.com/blog/post/introducing-full-stack-fast-api-app-generator-for-python-developers>`__
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure is modeled on the PHP page, as recommended in the ticket

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say "Full Stack FastAPI MongoDB App Generator"?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, do we want to direct users to this url rather than the blog post? https://github.com/mongodb-labs/full-stack-fastapi-mongodb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me. I originally linked to the blog post because it contains a link to the repo, but linking directly to the repo seems more consistent with the rest of our docs.

Copy link
Collaborator

@caitlindavey caitlindavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShaneHarvey ShaneHarvey requested a review from Jibola January 25, 2024 18:09
Copy link

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a discussion point.

source/python-drivers.txt Outdated Show resolved Hide resolved
@mongoKart mongoKart requested a review from Jibola March 15, 2024 14:01
Copy link

@Jibola Jibola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mongoKart mongoKart merged commit 0ebcc46 into mongodb:master Mar 19, 2024
1 check passed
@mongoKart mongoKart deleted the docsp-35856-generator-note branch March 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants