Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DOCSP-45898): release notes v1.14.1 #189

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

davidhou17
Copy link
Collaborator

@davidhou17 davidhou17 commented Dec 11, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - <https://jira.mongodb.org/browse/DOCSP-45898 >
Staging - https://deploy-preview-189--docs-kafka-connector.netlify.app/whats-new/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link

netlify bot commented Dec 11, 2024

👷 Deploy request for docs-kafka-connector pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 8caebe5

What's New in 1.14.1
--------------------

- Added support for the new Kafka SystemTime pattern, ``Time.SYSTEM``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, because Time.SYSTEM has always existed, Kafka just removed the pattern we were using, we could rephrase as:

- This fixes an issue introduced in Apache Kafka version 3.9 around the Kafka SystemTime class.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry I should have clarified that we can remove Added support for the new Kafka SystemTime pattern, ``Time.SYSTEM``. as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, fixed now

@davidhou17 davidhou17 requested a review from Calvinnix December 11, 2024 15:58
Copy link
Collaborator

@Calvinnix Calvinnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@davidhou17 davidhou17 merged commit 15c7ae9 into mongodb:master Dec 11, 2024
1 check passed
@davidhou17
Copy link
Collaborator Author

💚 All backports created successfully

Status Branch Result
v1.14

Questions ?

Please refer to the Backport tool documentation

davidhou17 added a commit that referenced this pull request Dec 11, 2024
[v1.14] Merge pull request #189 from davidhou17/DOCSP-45898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants