Upgrade to Storybook 8 #2687
Merged
Upgrade to Storybook 8 #2687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7322089 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
TheSonOfThomp
commented
Feb 4, 2025
packages/icon/turbo.json
Outdated
Comment on lines
7
to
8
| "inputs": ["src/glyphs/*.svg"], | ||
| "outputs": ["src/generated/*.tsx"] |
There was a problem hiding this comment.
Drive-by. Only miss the prebuild cache if src/glyphs changes
TheSonOfThomp
commented
Feb 4, 2025
Comment on lines
+42
to
+43
| "@storybook/manager-api": "8.5.3", | ||
| "@storybook/preview-api": "8.5.3", |
There was a problem hiding this comment.
/api and /addons were soft-deprecated in favor of these packages
https://storybook.js.org/docs/migration-guide#package-structure-changes
|
Size Change: +54 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
TheSonOfThomp
commented
Feb 5, 2025
Comment on lines
+76
to
+77
| "@testing-library/dom": "9.3.4", | ||
| "@testing-library/user-event": "13.5.0" |
There was a problem hiding this comment.
@bruugey @storybook/test was resolving an incompatible version of @testing-library/dom
TheSonOfThomp
requested review from
tsck and
bruugey
and removed request for
a team
|
Looks like there's some more testing issues! |
stephl3
reviewed
Feb 6, 2025
Comment on lines
14
to
15
| "@storybook/react": "^7.0.0", | ||
| "storybook": "^7.0.0" |
There was a problem hiding this comment.
why do these need to be dropped back to storybook 7?
There was a problem hiding this comment.
Not 100% sure if they do, but there are some transient dependencies on @testing-library that I want to make sure get resolved correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
LG-4188