[DOCS] make an explicit warning not to create clients for each request #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make an explicit warning not to create clients for each request
ShaneHarvey
requested changes
Feb 3, 2025
ShaneHarvey
reviewed
Feb 3, 2025
doc/tutorial-asyncio.rst
Outdated
| when your application starts and reuse that one client for the lifetime | ||
| of the process. You can maintain the client by storing a database handle | ||
| from the client on your application object, as shown in this example. | ||
| .. WARNING:: |
There was a problem hiding this comment.
Would you mind using lower case here (.. warning) to match our other uses? And same for the other file.
ShaneHarvey
previously approved these changes
Feb 18, 2025
ShaneHarvey
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super easy and common pitfall so it should be made extra obvious