-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(NODE-5361): use task groups for lambda #3740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
durran
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Jun 26, 2023
baileympearson
requested changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're only running this task every 14 days on main, should we be running it on PRs?
Otherwise, the changes look good.
I've removed now. |
baileympearson
approved these changes
Jun 28, 2023
baileympearson
changed the title
test(NODE-5361): use task groups for lambda
ci(NODE-5361): use task groups for lambda
Jun 28, 2023
malikj2000
pushed a commit
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches the deployed AWS Lambda tests to use task groups for more consistent setup and teardown.
What is changing?
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5361/DRIVERS-2657 and not losing money on orphaned Atlas clusters.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript