fix(NODE-6763): pass WriteConcernOptions instead on WriteConcernSettings #4421
+54
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
That PR should fix case of loosing write-concern options while using
timeoutMS
option.WriteConcern.fromOptions
static method accepts 3 options formats:WriteConcernOptions
objectWriteConcern
instanceW
typeBut in case of using
timeoutMS
options, utils functionresolveOptions
calls (link to code)WriteConcern.fromOptions
with options, which looks likeWriteConcern
instance, but there is no instance and more look likeWriteConcernSettings
type:So that call return
undefined
as "parsing failed" and command losses write-concern context.What is changing?
I changed options format to be consistent with
WriteConcern.fromOptions
type and useWriteConcernOptions
format.Is there new documentation needed for these changes?
No.
What is the motivation for this change?
It's a probably bug.
I used mongodb driver within mongoose and find out
updateMany
command withwriteConcern
andtimeoutMS
options does not pass write-concern context toCommanStartedEvent
. This small fix should be helpful.Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript