test(NODE-6745): only find python when installing native #4422
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
durran
commented
Feb 18, 2025
| @@ -32,7 +32,7 @@ export PATH="$MONGODB_BINARIES:$PATH" | |||
|
|
|||
| if [ ! -d "$DRIVERS_TOOLS" ]; then | |||
| # Only clone driver tools if it does not exist | |||
| git clone --depth=1 "https://github.com/mongodb-labs/drivers-evergreen-tools.git" "${DRIVERS_TOOLS}" | |||
| git clone --depth=1 --branch NODE-6745 "https://github.com/mongodb-labs/drivers-evergreen-tools.git" "${DRIVERS_TOOLS}" | |||
There was a problem hiding this comment.
Will revert back after tools merge.
durran
changed the title
baileympearson
added
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts changes in tools for finding python3 that broken the AWS ECS tests. Companion PR: mongodb-labs/drivers-evergreen-tools#602
What is changing?
Moves the forced python3 find into our install dependencies script only when testing functionality with a native module.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-6745
mongodb-labs/drivers-evergreen-tools#602
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript