feat: update changelog convert format to move Backward Compatible as …

…last item (#208)
mongodb · Aug 29, 2024 · b6ff3e4 · b6ff3e4
1 parent 0e8cd84
commit b6ff3e4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tools/cli/internal/cli/changelog/convert/slack.go b/tools/cli/internal/cli/changelog/convert/slack.go
@@ -150,8 +150,8 @@ func newAttachmentFromChange(version, method, path string, change *changelog.Cha
 
 func newAttachmentText(version, method, path, changeCode, change, backwardCompatible, hiddenFromChangelog string) string {
 	return fmt.Sprintf(
-		"\n• *Version*: `%s`\n• *Path*: `%s %s`\n• *Backward Compatible*: `%s`\n• *Hidden from Changelog*: `%s`\n• *Change Code*: `%s`\n• *Change*: `%s`",
-		version, method, path, backwardCompatible, hiddenFromChangelog, changeCode, change)
+		"\n• *Version*: `%s`\n• *Path*: `%s %s`\n• *Hidden from Changelog*: `%s`\n• *Change Code*: `%s`\n• *Change*: `%s`\n• *Backward Compatible*: `%s`",
+		version, method, path, hiddenFromChangelog, changeCode, change, backwardCompatible)
 }
 
 func newColorFromBackwardCompatible(backwardCompatible bool) string {

diff --git a/tools/cli/internal/cli/changelog/convert/slack_test.go b/tools/cli/internal/cli/changelog/convert/slack_test.go
@@ -41,7 +41,7 @@ func TestNewAttachmentText(t *testing.T) {
 			change:              "added the new DUBLIN_IRL, FRANKFURT_DEU, LONDON_GBR enum values",
 			backwardCompatible:  "true",
 			hiddenFromChangelog: "false",
-			expected:            "\n• *Version*: `2024-08-05`\n• *Path*: `GET /api/atlas/v2/groups/{groupId}/clusters`\n• *Backward Compatible*: `true`\n• *Hidden from Changelog*: `false`\n• *Change Code*: `response-property-enum-value-added`\n• *Change*: `added the new DUBLIN_IRL, FRANKFURT_DEU, LONDON_GBR enum values`", //nolint:lll //Test string
+			expected:            "\n• *Version*: `2024-08-05`\n• *Path*: `GET /api/atlas/v2/groups/{groupId}/clusters`\n• *Hidden from Changelog*: `false`\n• *Change Code*: `response-property-enum-value-added`\n• *Change*: `added the new DUBLIN_IRL, FRANKFURT_DEU, LONDON_GBR enum values`\n• *Backward Compatible*: `true`", //nolint:lll //Test string
 		},
 		{
 			name:                "Non-Backward Compatible Change",
@@ -52,7 +52,7 @@ func TestNewAttachmentText(t *testing.T) {
 			change:              "added the new optional request property replicaSetScalingStrategy",
 			hiddenFromChangelog: "true",
 			backwardCompatible:  "false",
-			expected:            "\n• *Version*: `2024-08-05`\n• *Path*: `POST /api/atlas/v2/groups/{groupId}/clusters`\n• *Backward Compatible*: `false`\n• *Hidden from Changelog*: `true`\n• *Change Code*: `new-optional-request-property`\n• *Change*: `added the new optional request property replicaSetScalingStrategy`", //nolint:lll //Test string
+			expected:            "\n• *Version*: `2024-08-05`\n• *Path*: `POST /api/atlas/v2/groups/{groupId}/clusters`\n• *Hidden from Changelog*: `true`\n• *Change Code*: `new-optional-request-property`\n• *Change*: `added the new optional request property replicaSetScalingStrategy`\n• *Backward Compatible*: `false`", //nolint:lll //Test string
 		},
 	}