Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOP-5110: Convert nested list-tables into nested rows #643

Closed
wants to merge 8 commits into from
Closed

DOP-5110: Convert nested list-tables into nested rows #643

wants to merge 8 commits into from

Conversation

rayangler
Copy link
Collaborator

@rayangler rayangler commented Feb 3, 2025 •
edited
Loading

Ticket

DOP-5110
Related frontend PR

Notes

  • This approach assumes that the first nested list-table inside a cell of a list-table will be used as the cut-off for a sub/nested row's cell. The nested list-table and any subsequent sibling of the nested list-table will be included as part of the same sub row cell.
  • If we plan on supporting subs rows and expandable content as part of future work, I went ahead and spoofed row and cell directives that we can potentially reuse and create formal declarations for in rstspec.toml whenever needed.

README updates

    • This PR introduces changes that should be reflected in the README.md and/or HACKING.md, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README.md and/or HACKING.md

@rayangler rayangler mentioned this pull request Feb 3, 2025
Closed
@rayangler rayangler requested review from seungpark and mmeigs February 3, 2025 16:54
seungpark
seungpark approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@seungpark seungpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM. thanks for taking the time to explain the approach! 💯

snooty/postprocess.py Show resolved Hide resolved
mmeigs
mmeigs approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@mmeigs mmeigs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@rayangler
Copy link
Collaborator Author

Closing this PR due to discussions leaning towards a no-op on our end. Please refer to the ticket comments for details.

@rayangler rayangler closed this Feb 11, 2025
@rayangler rayangler deleted the DOP-5110-nested-rows branch February 11, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seungpark seungpark seungpark approved these changes

@mmeigs mmeigs mmeigs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayangler @seungpark @mmeigs