Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOP-5329: Osiris TOC #646

Merged
merged 5 commits into from
Feb 14, 2025
Merged

DOP-5329: Osiris TOC #646

merged 5 commits into from
Feb 14, 2025

Conversation

mmeigs
Copy link
Collaborator

@mmeigs mmeigs commented Feb 12, 2025

Ticket

DOP-5329

Notes

Adds ability to deserialize toctree nodes.

Uses new osiris property osiris_parent to delineate which toctree nodes should not be drawers.

Necessary for this Osiris PR.

README updates

    • This PR introduces changes that should be reflected in the README.md and/or HACKING.md, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README.md and/or HACKING.md

@mmeigs mmeigs changed the title Dop 5329 osiris toc DOP-5329: TOC Feb 12, 2025
@mmeigs mmeigs changed the title DOP-5329: TOC DOP-5329: Osiris TOC Feb 12, 2025
Copy link
Collaborator

@rayangler rayangler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of less lgtm. Just a couple of comments to help with linting

@mmeigs mmeigs requested a review from rayangler February 13, 2025 14:47
@mmeigs mmeigs merged commit c0d1856 into main Feb 14, 2025
5 checks passed
@mmeigs mmeigs deleted the DOP-5329-osiris-toc branch February 14, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants