Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for #244 and #245 #246

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixes for #244 and #245 #246

wants to merge 4 commits into from

Conversation

vanboom
Copy link

@vanboom vanboom commented Jul 22, 2020

#244 - allow the tracker to track embedded relations

#245 - handle nil original value for an embeds_many relation

@mongoid-bot
Copy link

mongoid-bot commented Jul 22, 2020

2 Warnings
⚠️ There’re library changes, but not tests. That’s OK as long as you’re refactoring existing code.
⚠️ Unless you’re refactoring existing code, please update CHANGELOG.md.

Here's an example of a CHANGELOG.md entry:

* [#246](https://github.com/mongoid/mongoid-history/pull/246): Fixes for #244 and #245 - [@vanboom](https://github.com/vanboom).

Generated by 🚫 danger

@dblock
Copy link
Collaborator

dblock commented Jul 23, 2020

Thanks, this needs tests and changelog, please.

@dblock
Copy link
Collaborator

dblock commented Sep 22, 2020

Bump?

@johnnyshields
Copy link
Member

#244 looks suspect, the line should not be removed. I'll take a look later at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants