-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add invert output option #462
Conversation
another one need a conflict correction 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks good but there is one more thing - when constructing components, we need to reset output to non-inverted as a common baseline, so for example if you change switch into window covering, that know nothing about inverting outputs, outputs do not remain inverted.
it's not ideal, and represents a leak in abstractions, so if you have better idea how to manage it - welcome.
but for now, we'll need something similar to this.
mos.yml
Outdated
@@ -40,6 +40,7 @@ config_schema: | |||
- ["sw", "o", {title: "Switch settings", abstract: true}] | |||
- ["sw.name", "s", "", {title: "Name of the switch"}] | |||
- ["sw.enable", "b", true, {title: "Enable this switch in the accessory"}] | |||
- ["sw.inverted", "b", true, {title: "Invert output, set to true for normally open output"}] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have in_inverted
, let's call this option out_inverted
Maybe I miss something, but I think we don't need to reset it. |
except it doesn't. |
673f788
to
239b03b
Compare
review applied |
i don't see changes to shelly_main |
239b03b
to
dc0fd8d
Compare
thanks for the hint, lost during a rebase |
merged, thanks! |
closes #408