Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Extractor DONT_OVERRIDE behavior #586

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

HolterPhylo
Copy link
Collaborator

makes DONT_OVERRIDE work
and processes files in DONT_OVERRIDE when GUID has changed, otherwise skip them

@monkeyman192
Copy link
Owner

doesn't this kind of defeat the purpose of the DONT_OVERRIDE?
If the GUID changes we should notify and maybe produce the new file somewhere else I guess. but processing the file I think is maybe not exactly right since we generally will just want to patch the existing file rather than overwriting it?

@HolterPhylo
Copy link
Collaborator Author

HolterPhylo commented Feb 20, 2024

If we just output a message or produce it elsewhere, we will still have to get to it to compare what/why the GUID changed to the existing one we have. If we leave it where it is, VS can show us just that and we can act on it more easily, I think.

Example with TkSceneNodeData.cs:
image

Using:
image

@HolterPhylo
Copy link
Collaborator Author

one improvement would be to not only target the 'Toolkit' folder (which is fixed at the moment, see var 'in_dir') but instead 'NMS' folder to find the 'struct_name' location but I do not know how to do it elegantly in python :)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants