Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore pre experimental field order when serialising to exml #597

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

Auburn
Copy link

@Auburn Auburn commented Apr 24, 2024

Take declared field order from the exe and use that to restore field order in exml

I only did some quick testing on this, but it seems to work as expected. The MBINs retain the new ordering

Take declared field order from the exe and use that to restore field order in exml
@monkeyman192
Copy link
Owner

Thanks for this!
It looks great.

I ran the extractor and sorted out the resulting files and the EXML fields now look to be in the same order as before the changes.
The only issue remaining is that list data which gets serialized is "exml field" order, but the way mbincompiler serializes list data means that it will serialize the data in lists in the order of the fields in the mbin, not in the exml.
I think this can be merged anyway despite that.

@monkeyman192 monkeyman192 merged commit ea608bc into monkeyman192:development Apr 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants