Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkiaSharpSample project now default startup project in the WPF SkiaSharpSample solution #1369

Merged
merged 1 commit into from
Jun 30, 2020
Merged

SkiaSharpSample project now default startup project in the WPF SkiaSharpSample solution #1369

merged 1 commit into from
Jun 30, 2020

Conversation

TysonMN
Copy link
Contributor

@TysonMN TysonMN commented Jun 30, 2020

Description of Change

In the samples\Gallery\WPF\SkiaSharpSample.sln solution, I made the SkiaSharpSample project the default startup project by listing it first in the sln file.

API Changes

None

Behavioral Changes

No runtime changes.

This change improves the development experience. When first cloning the repo or after deleting the samples\Gallery\WPF\.vs folder and then opening samples\Gallery\WPF\SkiaSharpSample.sln with Visual Studio, the default startup project will now be the SkiaSharpSample project. This is an improvement because it is the only project that can be started.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • [NA] Updated documentation

@mattleibow mattleibow merged commit 695c352 into mono:master Jun 30, 2020
@mattleibow
Copy link
Contributor

Thanks for this.

@TysonMN TysonMN deleted the better_default_startup_in_SkiaSharpSample branch June 30, 2020 04:51
@mattleibow mattleibow added this to the v2.80.0 milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants