-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows entities to be extended by a custom parent class #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Prometee The null properties are correct. We use them to avoid issues with Doctrine, since you can't access a property which hasn't been set in the first place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
And I think we will leave for later the last point of the TODO concerning the entity override test.
@lanfisis or @delyriand Can you run one last time the build to see if everything is ok ? |
Done, it's running |
Thank you @Prometee the doctrine is not up to date, if I run a
It seems the default value is |
@maximehuran that's what I saw to, I just fixed it 😉 |
It stills have
|
@maximehuran my bad I did not scroll right 😅 |
Thank you very much @Prometee 🫶 |
This PR is allowing to extends the 2 Doctrine entities available.
protected
instead ofprivate
.Note: I saw some entity properties are nullable but they aren't when you look at the database schema definition.