Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flag to allow active descriptors in listeners #122

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add flag to allow active descriptors in listeners #122

wants to merge 5 commits into from

Commits on Apr 14, 2015

  1. Add flag to allow active descriptors in listeners 

    There are times when listeners might want to make changes that trigger
further events in a collection.  I had a bug in my code around this
point and only realized that further collection changes are suppressed
by default.  This patch adds an override flag to allow for descriptors
to fire their listeners again even if currently active.

Signed-off-by: Fred Kilbourn <[email protected]>
    @fredkilbourn
    fredkilbourn committed Apr 14, 2015
    Configuration menu
    Copy the full SHA
    bde107c View commit details
    Browse the repository at this point in the history

  2. Add missing allowActive args on addBefore calls 

    Signed-off-by: Fred Kilbourn <[email protected]>
    @fredkilbourn
    fredkilbourn committed Apr 14, 2015
    Configuration menu
    Copy the full SHA
    c5fe9e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2015

  1. Merge pull request #1 from montagejs/master 

    Updating master
    @fredkilbourn
    fredkilbourn committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    edcf8cc View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from fredkilbourn/master 

    Merge
    @fredkilbourn
    fredkilbourn committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    6d76915 View commit details
    Browse the repository at this point in the history

  3. Rename allowActive to allowsNestedDispatch 

    - Clean up implementation, update comments
- Also implement in property-changes.js
- Make sure isActive and allowsNestedDispatch keys are defined respective
  get(Map|Property|Range)ChangeDescriptor methods

Signed-off-by: Fred Kilbourn <[email protected]>
    @fredkilbourn
    fredkilbourn committed Jun 1, 2015
    Configuration menu
    Copy the full SHA
    c198385 View commit details
    Browse the repository at this point in the history