CCS/t/03_ufuncs.t assign data of correct type #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12427419214Details
💛 - Coveralls |
moocow-the-bovine
approved these changes
Dec 20, 2024
|
@mohawk2 d'oh ... sorry, didn't see this in time: I've just made some related changes here & already released them. I'll go ahead & merge this now, and I guess release again later today ... unless you have anything else CCS-related in the pipeline? |
|
... released as PDL-CCS-1.23.27 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of fixing the problem discussed in the second section of https://pdl.perl.org/advent/blog/2024/12/20/pdl-internals/, I made PDL reject assigning into a slice with the output of a type-conversion. That includes the code tweaked here.
As you can see at the bottom of that article, and in PDLPorters/pdl#511, I'm probably going to take a different route to fixing the problem. But because this change here will reduce type-conversions, I felt it worth submitting anyway.
If you like it, please could you merge and release it quite soon? That would help me.