Skip to content

Commit

Permalink
Remove task to remind devs about writing lang strings properly
Browse files Browse the repository at this point in the history
I have checked with Helen and we agreed that this task is not necessary
and can be removed because wordings are already supposedly covered by
the peer review stage:
https://moodledev.io/general/development/process/peer-review#language
  • Loading branch information
junpataleta committed Feb 27, 2024
1 parent 30af0cb commit 5a3fccb
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions general/development/process/release/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ sidebar_position: 7
| 2. | ✓ | | Ensure we are running latest/good behat, phpunit and nodejs (npm) versions. | Integration Team |
| 3. | ✓ | | Confirm external testers daily availability from -7w to release (internally with dev manager and then, externally, with contractors). They start in just 1 week! | Integration Team |
| 4. | &#10003; | | <ul><li>Move QA tests for new features in old release with automated tests from [MDLQA-1](https://tracker.moodle.org/browse/MDLQA-1) to [MDLQA-5249](https://tracker.moodle.org/browse/MDLQA-5249).</li><li>Remind developers to add the `qa_test_required` label to the tracker issue of new features/improvements that get integrated without automated tests. Developers need to comment on what needs to be covered by the QA test and indicate if the issue's testing instructions, or part of it, can be used to write the QA test.</li></ul> | Testing Maintainer |
| 5. | &#10003; | | Remind developers to write the best possible language strings for their patches on their first attempt instead of relying on `en_fix`, which usually gets integrated in the last two weeks of the release cycle. Getting the language strings right the first time will help make the translators' lives easier, given the proximity of the major release and the need to facilitate the work of translators and others. | English fixes lang pack maintainer |
| 6. | &#10003; | | <ul><li>Create a "Must fix for X.Y" version in the Tracker and adjust the ["TR - Set integration priority to one"](https://ci.moodle.org/view/Tracker/job/TR%20-%20Set%20integration%20priority%20to%20one/) and ["TR - Move reopened out from current"](https://ci.moodle.org/view/Tracker/job/TR%20-%20Move%20reopened%20out%20from%20current/) jobs in **all CI servers** to point to it.</li><li>Comment about its creation within HQ so people can apply this to the "Fix Version/s" field in the Tracker.</li><li>Confirm that the following filters based on the [All "must fix" issues](https://tracker.moodle.org/issues/?filter=21363) filter, and are used on the [Release urgent dashboard](https://tracker.moodle.org/secure/Dashboard.jspa?selectPageId=16582), look and work as expected:<ul><li>[release urgent - Peer review list](https://tracker.moodle.org/issues/?filter=18596)</li><li>[release urgent (must fix) - up for grabs](https://tracker.moodle.org/issues/?filter=18594)</li><li>[release urgent- current HQ work](https://tracker.moodle.org/issues/?filter=18861)</li></ul></li><li>Rename the [Release urgent dashboard](https://tracker.moodle.org/secure/Dashboard.jspa?selectPageId=16582) to indicate the version for the upcoming release (QA part of the dashboard will not work yet)</li></ul> | Integration Team |
| 5. | &#10003; | | <ul><li>Create a "Must fix for X.Y" version in the Tracker and adjust the ["TR - Set integration priority to one"](https://ci.moodle.org/view/Tracker/job/TR%20-%20Set%20integration%20priority%20to%20one/) and ["TR - Move reopened out from current"](https://ci.moodle.org/view/Tracker/job/TR%20-%20Move%20reopened%20out%20from%20current/) jobs in **all CI servers** to point to it.</li><li>Comment about its creation within HQ so people can apply this to the "Fix Version/s" field in the Tracker.</li><li>Confirm that the following filters based on the [All "must fix" issues](https://tracker.moodle.org/issues/?filter=21363) filter, and are used on the [Release urgent dashboard](https://tracker.moodle.org/secure/Dashboard.jspa?selectPageId=16582), look and work as expected:<ul><li>[release urgent - Peer review list](https://tracker.moodle.org/issues/?filter=18596)</li><li>[release urgent (must fix) - up for grabs](https://tracker.moodle.org/issues/?filter=18594)</li><li>[release urgent- current HQ work](https://tracker.moodle.org/issues/?filter=18861)</li></ul></li><li>Rename the [Release urgent dashboard](https://tracker.moodle.org/secure/Dashboard.jspa?selectPageId=16582) to indicate the version for the upcoming release (QA part of the dashboard will not work yet)</li></ul> | Integration Team |

## 7 weeks prior

Expand Down

0 comments on commit 5a3fccb

Please sign in to comment.