-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to handle privacy providers that only store data in a sub-system #1105
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
The lighthosue test seems to have failed while waiting for an external site to build something (I'm guessing the docs), is that likely to just be that tool/website being slow when this ran? From looking at the test I am not certain that there is anything I can do about that one. |
I realised that I should probably modify the docs for all versions of Moodle |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just a minor change to the display of code and a clarification where the get_metadata()
method that needs to be implemented is.
Thanks for the feedback I have implemented the changes |
It appears that this is not clear to everyone who reads the documentation at the moment that a plugin that sends data to a subsystem, for example the logs should not use the null_provider and that the sub-system will do the retrieval and deletion of the personal data. This has been the case in all versions of Moodle supported by the dev docs.
The spelling error appears to be unconnected to this change, it seems to be talking about line 112 of the ai placements documentation (which is odd since that word does not appear on that line)
|
I have rebased it onto the latest changes to see if that fixes it. |
Thanks. I have a fix for that in another issue up for PR |
It appears that this is not clear to everyone who reads the documentation at the moment that a plugin that sends data to a subsystem, for example the logs should not use the null_provider and that the sub-system will do the retrieval and deletion of the personal data.