[docs] Added new parameter @notify to file creation function - MDL-75850 #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
ilyatregubov
requested changes
Sep 9, 2024
| @@ -293,6 +293,19 @@ $fs = get_file_storage(); | |||
| $fs->create_file_from_storedfile($fileinfo, $existingfile); | |||
| ``` | |||
|
|
|||
| #### Notification requirements for new files | |||
|
|
|||
| By default, the `$notify` parameter has a value of `true` and will call the after_file_created hook after files are created. If you prefer not to do this, you can set it to `false`. | |||
There was a problem hiding this comment.
This is very unclear. What parameter? Of which function? What are we trying to achieve? I would mentioned the function directly and explained a new argument meaning - thery is no connection between argument name notufy and the fact that we are calling come hook. And same appies to the section name - what requirement is meant?
|
I am closing this one because there are changes that make the notification unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is blocked by MDL-75850