[docs] Update information about modal instantiation (MDL-78324) #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
andrewnicols
force-pushed
the
MDL-78324
branch
from
2b658bf
to
d080e7e
Compare
sarjona
added
the
blocked-by-tracker
We were able to deprecate the modal_factory entirely in 4.3, so for new code aimed at 4.3 onwards, there is no need to register. The new registration process is only available for 4.3 onwards, so it no longer makes sense to document this. Code aimed at versions including 4.2 and older will still need to register using the previous mechanism.
andrewnicols
force-pushed
the
MDL-78324
branch
from
d080e7e
to
c56f736
Compare
junpataleta
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
Looks spot-on to me. Thanks, Andrew!
A separate issue, but I noticed an empty Modals section within the JavaScript page. I wonder if we should just remove that as we already have the proper page for the modal documentation.
I'll leave it up to you if you want to tidy that up in this pull request or raise a separate PR for it.
Cheers!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.