Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDL-78806 better page title documentation #729

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

junpataleta
Copy link
Collaborator

@junpataleta junpataleta commented Sep 12, 2023

Dev docs for when MDL-78806 gets integrated

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0f91708
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6501d41a1ef95f0008f6838c
😎 Deploy Preview https://deploy-preview-729--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 70 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🔴 42 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 56 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🔴 46 🟠 87 🟢 92 🟢 100 🟢 100 Report

general/development/policies/accessibility.md Outdated Show resolved Hide resolved
general/development/policies/accessibility.md Outdated Show resolved Hide resolved
general/development/policies/accessibility.md Outdated Show resolved Hide resolved
general/development/policies/accessibility.md Outdated Show resolved Hide resolved
general/development/policies/accessibility.md Outdated Show resolved Hide resolved
general/development/policies/accessibility.md Outdated Show resolved Hide resolved
Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I think we need to be careful and re-assess the example:

// Activity name and its sub-page as the unique identifying information.
$pagename = format_string($cm->name) . ': ' . get_string('view');

This is a great example of lang string concatenation, which we should avoid where possible.

@andrewnicols andrewnicols added this pull request to the merge queue Sep 18, 2023
Merged via the queue into moodle:main with commit 7164174 Sep 18, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants