Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add missing SVG files to devupdate #732

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Sep 13, 2023

Add a reference in devupdate page for Moodle 4.3 to explain the changes done about SVG files in https://tracker.moodle.org/browse/MDL-67271

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 869b7d3
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6501d2dea4f8f70008fdcc03
😎 Deploy Preview https://deploy-preview-732--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 72 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🔴 43 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 53 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 52 🟠 87 🟢 92 🟢 100 🟢 100 Report

Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this pending the Friday roll.

One query - is there any tooling to make this easier, or any documentation on how to do so?

@sarjona
Copy link
Member Author

sarjona commented Sep 13, 2023

Hi @andrewnicols!
Thanks for reviewing this PR! You raised an interesting point so I've added one more sentence to the page to explain the way to update missing SVG in Moodle LMS. I hope it makes sense to you and answers your question (as you'll see, we basically search for the current icon in the FontAwesome database) :-)

@andrewnicols andrewnicols added this pull request to the merge queue Sep 19, 2023
Merged via the queue into moodle:main with commit ca0df55 Sep 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants