Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app setup instructions #733

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

NoelDeMartin
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 13, 2023

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 240fa6a
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6501a2ba667c65000801ffb6
😎 Deploy Preview https://deploy-preview-733--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 51 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🔴 39 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🔴 45 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🔴 42 🟠 87 🟢 92 🟢 100 🟢 100 Report

Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Noel,

Whilst these changes are correct, I wonder if it may be worth suggesting the use of Chrome for Testing:
https://developer.chrome.com/blog/chrome-for-testing/

It's a separate version of Chromium for the purpose of testing and with automatic updates disabled.

@NoelDeMartin
Copy link
Contributor Author

Thanks @andrewnicols for the suggestion, I wasn't familiar with "Chrome for Testing", I'll check it out.

However, for this PR, I think it's better if we go ahead with the merge because we're interested in getting it live before the DevJam. We thought this 119 version of Chrome wouldn't be a problem until November, but we just realized it's already being distributed for Chrome canary and Chromium so it can potentially affect some people :(.

We could update it to suggest using Chrome for Testing. But considering that it's the first time we hear about it in our team and none of us has used it, I'm prefer to keep suggesting Chromium which is what we all use. Eventually, when we test it ourselves, we can update the documentation.

@andrewnicols andrewnicols added this pull request to the merge queue Sep 14, 2023
Merged via the queue into moodle:main with commit ccfe2b6 Sep 14, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants