-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app setup instructions #733
Update app setup instructions #733
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Noel,
Whilst these changes are correct, I wonder if it may be worth suggesting the use of Chrome for Testing:
https://developer.chrome.com/blog/chrome-for-testing/
It's a separate version of Chromium for the purpose of testing and with automatic updates disabled.
Thanks @andrewnicols for the suggestion, I wasn't familiar with "Chrome for Testing", I'll check it out. However, for this PR, I think it's better if we go ahead with the merge because we're interested in getting it live before the DevJam. We thought this 119 version of Chrome wouldn't be a problem until November, but we just realized it's already being distributed for Chrome canary and Chromium so it can potentially affect some people :(. We could update it to suggest using Chrome for Testing. But considering that it's the first time we hear about it in our team and none of us has used it, I'm prefer to keep suggesting Chromium which is what we all use. Eventually, when we test it ourselves, we can update the documentation. |
No description provided.