Meta enrolment in csv course upload #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ilyatregubov
commented
Nov 17, 2023
ilyatregubov
commented
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
ilyatregubov
force-pushed
the
meta-enrolment-in-csv-course-upload
branch
from
a355b5f
to
2df22c3
Compare
sarjona
requested changes
Dec 1, 2023
There was a problem hiding this comment.
Hi @ilyatregubov!
Thanks a lot for preparing a patch for this. As you'll see, I added a few minor proposals to improve it :-)
MDL-73852 changes
ilyatregubov
force-pushed
the
meta-enrolment-in-csv-course-upload
branch
from
1935ad9
to
3f02243
Compare
|
All issues have been resolved. Just need someone to approve |
sarjona
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Hi @ilyatregubov!
Thanks for reviewing the patch. I'm happy to approve and merge it. Well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.