Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Gitpod integration with Moodle #825

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Dec 1, 2023

This issue is to document the integration with Gitpod that I implemented during my project week: https://github.com/moodlehq/moodle-docker/#quick-start-with-gitpod

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 7550469
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/656f1a80ee54070008024a00
😎 Deploy Preview https://deploy-preview-825--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 74 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 67 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 67 🟠 87 🟢 92 🟢 100 🟢 100 Report

Copy link
Contributor

@juliavs85 juliavs85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, Sara! These are just some suggestions for tiny changes.

general/development/tools/gitpod.md Outdated Show resolved Hide resolved
general/development/tools/gitpod.md Outdated Show resolved Hide resolved
general/development/tools/gitpod.md Outdated Show resolved Hide resolved
general/development/tools/gitpod.md Outdated Show resolved Hide resolved
general/development/tools/gitpod.md Outdated Show resolved Hide resolved
general/development/tools/gitpod.md Outdated Show resolved Hide resolved
general/development/tools/gitpod.md Outdated Show resolved Hide resolved
@sarjona
Copy link
Member Author

sarjona commented Dec 5, 2023

Hi @juliavs85!
Thanks a lot for all these nice suggestions to improve this page! I applied them all, so the pull-request is ready to get your review again and confirm it's ready to be merged :-)

Copy link
Member Author

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is ready :-)

Copy link
Contributor

@juliavs85 juliavs85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@sarjona sarjona merged commit da3b68b into moodle:main Dec 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants