Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add working examples and some clarifications to inplace_edit #843

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

PM84
Copy link
Contributor

@PM84 PM84 commented Dec 19, 2023

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 97b5c96
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/661e045c9acc180008b60707
😎 Deploy Preview https://deploy-preview-843--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 19, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 69 🟠 87 🟢 100 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 61 🟠 85 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 71 🟠 87 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 76 🟠 87 🟢 100 🟢 100 🟢 100 Report

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PM84!

Thanks a lot for helping to improve this page. The examples look great. Well done.

However, I would suggest using the

element instead of creating a new subsection, "Working example", to hide them by default to make the page easier to read. I've created a branch to help to better understand what I mean (it's using your same examples, but reorganising the information): sarjona@inplacepr

Apart from this change, you should also add these changes to the file in the main branch (docs/apis/subsystems/output/inplace.md).

Please, let me know if there is anything I can do for helping you :-)

@andrewnicols
Copy link
Member

I've pulled in Sara's changes and applied them with a few tweaks. Merging.

@andrewnicols andrewnicols added this pull request to the merge queue Apr 16, 2024
Merged via the queue into moodle:main with commit a8371ee Apr 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants