Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for MDL-80259 #848

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

roland04
Copy link
Collaborator

@roland04 roland04 commented Jan 3, 2024

No description provided.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 79fe8ec
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/65b296a69d271500075c9648
😎 Deploy Preview https://deploy-preview-848--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 3, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 57 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 58 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 81 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 62 🟠 87 🟢 92 🟢 100 🟢 100 Report

@roland04 roland04 force-pushed the devdocs-bootstrap-badges branch 2 times, most recently from 7176f27 to c2eca6a Compare January 3, 2024 13:22
Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the changes exemplified here, this seems like a detrimental change to be making. Why are we making it?

docs/devupdate.md Outdated Show resolved Hide resolved
docs/devupdate.md Outdated Show resolved Hide resolved
docs/devupdate.md Outdated Show resolved Hide resolved
@roland04 roland04 force-pushed the devdocs-bootstrap-badges branch 2 times, most recently from 1c7852e to efb4842 Compare January 3, 2024 14:11
@roland04
Copy link
Collaborator Author

roland04 commented Jan 3, 2024

The origin of these changes is the Bootstrap 5 upgrade. According to the Bootstrap migration guide these badge classes will be dropped in version 5

@roland04 roland04 force-pushed the devdocs-bootstrap-badges branch 2 times, most recently from 9068af5 to 4f7a406 Compare January 5, 2024 08:03
@andrewnicols andrewnicols marked this pull request as draft January 9, 2024 07:05
@andrewnicols
Copy link
Member

Converting to draft to prevent accidental merge as the linked issues are not ready

@roland04 roland04 changed the title [docs] Devdovs Bootstrap badges refactor Documentation for MDL-80259 Jan 9, 2024
@roland04 roland04 marked this pull request as ready for review January 23, 2024 10:06
@aanabit aanabit added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Jan 23, 2024
@aanabit
Copy link
Collaborator

aanabit commented Jan 23, 2024

These changes seems OK to me and are ready to merge imho. They are waiting for MDL-80259 to be integrated, so I won't merge the PR for now.

@sarjona sarjona removed the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Jan 25, 2024
@sarjona sarjona disabled auto-merge January 25, 2024 17:25
@sarjona sarjona merged commit f9e4d2e into moodle:main Jan 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants