-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for MDL-80259 #848
Conversation
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
7176f27
to
c2eca6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the changes exemplified here, this seems like a detrimental change to be making. Why are we making it?
c2eca6a
to
c45e489
Compare
1c7852e
to
efb4842
Compare
The origin of these changes is the Bootstrap 5 upgrade. According to the Bootstrap migration guide these badge classes will be dropped in version 5 |
9068af5
to
4f7a406
Compare
Converting to draft to prevent accidental merge as the linked issues are not ready |
These changes seems OK to me and are ready to merge imho. They are waiting for MDL-80259 to be integrated, so I won't merge the PR for now. |
4f7a406
to
355e7e5
Compare
355e7e5
to
859d202
Compare
No description provided.