Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation for MDL-75670 #859

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Documentation for MDL-75670 #859

merged 1 commit into from
Mar 5, 2024

Conversation

roland04
Copy link
Collaborator

@roland04 roland04 commented Jan 9, 2024

No description provided.

@netlify Netlify
Copy link

netlify bot commented Jan 9, 2024 •
edited
Loading

✅ Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bc52ea5
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/65e6dcca074417000863d254
😎 Deploy Preview https://deploy-preview-859--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roland04 roland04 marked this pull request as draft January 9, 2024 08:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 37 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 67 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 66 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 61 🟠 87 🟢 92 🟢 100 🟢 100 Report

@roland04 roland04 changed the title [docs] Devdocs Bootstrap forms refactor Documentation for MDL-75670 Jan 9, 2024
@sarjona sarjona added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Jan 9, 2024
@roland04 roland04 marked this pull request as ready for review January 23, 2024 10:07
@roland04 roland04 force-pushed the devdocs-bootstrap-forms-2 branch 2 times, most recently from 45de835 to 464de4a Compare January 26, 2024 07:00
cescobedo
cescobedo approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@cescobedo cescobedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good @roland04 , thanks!
Wait for https://tracker.moodle.org/browse/MDL-75670 to land to press the merge button

aanabit
aanabit approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@aanabit aanabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the changes, and makes sense due to changes in MDL-75670

@sarjona sarjona added this pull request to the merge queue Mar 5, 2024
Merged via the queue into moodle:main with commit 123da7a Mar 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanabit aanabit aanabit approved these changes

@cescobedo cescobedo cescobedo approved these changes

Assignees
No one assigned
Labels
blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roland04 @cescobedo @aanabit @sarjona