Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing description parameters in external_value constructor all #860

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

PhMemmel
Copy link
Contributor

@PhMemmel PhMemmel commented Jan 9, 2024

No description provided.

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 716a743
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/65a4edc1971f610008a4e3b2
😎 Deploy Preview https://deploy-preview-860--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 89 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 54 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 68 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 67 🟠 87 🟢 92 🟢 100 🟢 100 Report

Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies - they were worse than we all feared.

docs/apis/subsystems/external/writing-a-service.md Outdated Show resolved Hide resolved
docs/apis/subsystems/external/writing-a-service.md Outdated Show resolved Hide resolved
docs/apis/subsystems/external/writing-a-service.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@PhMemmel PhMemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @andrewnicols!

I tried to include your suggestions.

Is it possible you were confusing PARAM_ and VALUE_ prefixes? Please have another look at my changes. From my point of view it now everything should be correct, but of course I can be wrong :)

docs/apis/subsystems/external/writing-a-service.md Outdated Show resolved Hide resolved
docs/apis/subsystems/external/writing-a-service.md Outdated Show resolved Hide resolved
docs/apis/subsystems/external/writing-a-service.md Outdated Show resolved Hide resolved
Copy link
Member

@andrewnicols andrewnicols left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, and demonstrates both options.

Copy link
Contributor Author

@PhMemmel PhMemmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I forgot to push my commit, so my comments probably seemed to be pretty confusing :) Now pushed the commit.

@andrewnicols andrewnicols added this pull request to the merge queue Jan 15, 2024
Merged via the queue into moodle:main with commit 6af6a07 Jan 15, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants