Changes for MDL-80677

[andrewnicols]

No description provided.

[netlify]

✅ Deploy Preview for moodledevdocs ready!

Name	Link
🔨 Latest commit	bcec4ae
🔍 Latest deploy log	https://app.netlify.com/sites/moodledevdocs/deploys/65ef14a4c24d9700081dc7ff
😎 Deploy Preview	https://deploy-preview-868--moodledevdocs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🟠 50	🟠 87	🟢 92	🟢 90	🟢 100	Report
/docs/apis/commonfiles	🟠 70	🟠 85	🟢 92	🟢 100	🟢 100	Report
/general/development/gettingstarted	🟠 80	🟠 87	🟢 92	🟢 90	🟢 100	Report
/general/releases	🟠 65	🟠 87	🟢 92	🟢 100	🟢 100	Report

[junpataleta]

Thanks, Andrew! This looks good to me overall.

Should we also update the Deprecation policy to provide information on using the core/deprecated attribute and core/deprecation during initial and final deprecation?

[andrewnicols]

I considered this but I don't know. It's not intended to replace the current deprecation, but to aid it. Maybe a note like:

:::note

From Moodle 4.4 onwards, you may wish to use the `\core\deprecated` attribute in combination with the `\core\deprecation` class to emit this message.

:::

[timhunt]

The buggest problem with Moodle deprectation messages is that people tell you to stop doing something without telling you what to do instead.

If what to do instead is not requred information, this is moving deckchairs on the Titanic. Certainly, all the give examples in the new docs should set a good example "reason: 'No longer required'," is so bad, it is basically a parody, right?

[andrewnicols]

Thanks for the feedback Tim.

I thought about making this a required field, but there is not always a replacement. Sometimes things are just removed and that should be mentioned in the reason.

Do you have a better suggestion on how we can do this?

[timhunt]

When you say "I thought about making this a required field, but there is not always a replacement. Sometimes things are just removed and that should be mentioned in the reason." you are thinking about things from the wrong angle.

Think about things from the point of view as a plugin developer.

You don't just call Moodle core APIs for a laugh. Any time you are calling a core API, an you are trying to achieve some end goal on behalf of the user.

Generally, Moodle does not make it impossible to do things that were possible in the past. There must always be some sort of new recommended way to do thin thing that you were doing the old way.

Anyway, when you make an API change that broke my plugin, I don't really care why you thought it was a good idea. I just want to know what I should do now in my code. So, that should be the required information.