Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Dev update Bootstrap mixins refactor - MDL-80395 #874

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

sarjona
Copy link
Member

@sarjona sarjona commented Jan 26, 2024

This is for documenting changes in https://tracker.moodle.org/browse/MDL-80395. In BS5 some previously deprecated mixins are dropped. They can be refactored without waiting for the BS upgrade.

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 5922336
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/65ddca54d2118f00084a86dd
😎 Deploy Preview https://deploy-preview-874--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 26, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🔴 16 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 68 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 68 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 78 🟠 87 🟢 92 🟢 100 🟢 100 Report

@sarjona sarjona added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Jan 26, 2024
Copy link
Collaborator

@roland04 roland04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good @sarjona, thanks!
Wait for https://tracker.moodle.org/browse/MDL-80395 to land to press the merge button

Copy link
Collaborator

@aanabit aanabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem OK to me.

This is for documenting changes in https://tracker.moodle.org/browse/MDL-80395.
In BS5 some previously deprecated mixins are dropped. They can be
refactored without waiting for the BS upgrade.
@sarjona sarjona removed the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Mar 1, 2024
@sarjona sarjona added this pull request to the merge queue Mar 1, 2024
Merged via the queue into moodle:main with commit e9541a0 Mar 1, 2024
7 checks passed
@sarjona sarjona deleted the mixins branch March 1, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants