Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add docs for array notated hook callbacks #915

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

andrewnicols
Copy link
Member

Docs for MDL-81180

@andrewnicols andrewnicols self-assigned this Mar 8, 2024
@andrewnicols andrewnicols added the blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/ label Mar 8, 2024
Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit 680830b
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/65eec71304abf000088ba411
😎 Deploy Preview https://deploy-preview-915--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 65 🟠 87 🟢 92 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🟠 72 🟠 85 🟢 92 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 82 🟠 87 🟢 92 🟢 90 🟢 100 Report
/general/releases 🟠 65 🟠 87 🟢 92 🟢 100 🟢 100 Report

@mickhawkins mickhawkins self-requested a review March 11, 2024 08:26
Copy link
Collaborator

@mickhawkins mickhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrewnicols I just found a few minor errors, can you please address those?

docs/apis/core/hooks/index.md Show resolved Hide resolved
docs/apis/core/hooks/index.md Show resolved Hide resolved
docs/devupdate.md Show resolved Hide resolved
@andrewnicols
Copy link
Member Author

Thanks Mick,

All addresed.

Copy link
Collaborator

@mickhawkins mickhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew, confirmed those are all addressed.

@snake snake added this pull request to the merge queue Mar 15, 2024
Merged via the queue into moodle:main with commit 9f5783f Mar 15, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked-by-tracker This issue is blocked by an issue in https://tracker.moodle.org/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants