Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Communication subsystem docs update for MDL-78551 #925

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

safatshahin
Copy link
Contributor

Some more API's added as a part of MDL-78551, adding docs for them.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for moodledevdocs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1166874
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/6625d234a0c5ad00086698bc
😎 Deploy Preview https://deploy-preview-925--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Mar 19, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 79 🟢 95 🟢 100 🟢 90 🟢 100 Report
/docs/4.4/apis/commonfiles 🟠 74 🟢 93 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 78 🟢 95 🟢 100 🟢 90 🟢 100 Report
/general/releases 🟠 81 🟢 95 🟢 100 🟢 100 🟢 100 Report

@HuongNV13 HuongNV13 self-requested a review April 8, 2024 04:29
Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @safatshahin!
Thanks for improving the communication API docs to include changes implemented in https://tracker.moodle.org/browse/MDL-78551
As you'll see, I left a few points that should be clarified before merging this patch. TIA!

docs/apis/subsystems/communication/index.md Show resolved Hide resolved
docs/apis/subsystems/communication/index.md Outdated Show resolved Hide resolved
docs/apis/subsystems/communication/index.md Show resolved Hide resolved
@HuongNV13 HuongNV13 removed their request for review April 11, 2024 04:15
@safatshahin safatshahin force-pushed the MDL-78551 branch 2 times, most recently from 6f50adf to 43126c3 Compare April 22, 2024 02:55
@safatshahin
Copy link
Contributor Author

Hi @sarjona
Thank you for your comments. I have resolved all of them and made the changes.
Please have a look now.
Cheers!

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @safatshahin!
Thanks for reviewing and considering my comments :-)
I'm happy to approve and merge this :-)

@sarjona sarjona added this pull request to the merge queue Apr 22, 2024
Merged via the queue into moodle:main with commit 46c09cb Apr 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants