-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Communication subsystem docs update for MDL-78551 #925
Conversation
✅ Deploy Preview for moodledevdocs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @safatshahin!
Thanks for improving the communication API docs to include changes implemented in https://tracker.moodle.org/browse/MDL-78551
As you'll see, I left a few points that should be clarified before merging this patch. TIA!
6f50adf
to
43126c3
Compare
Hi @sarjona |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HI @safatshahin!
Thanks for reviewing and considering my comments :-)
I'm happy to approve and merge this :-)
Some more API's added as a part of MDL-78551, adding docs for them.