Bisect behat #118
Merged
Bisect behat #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If GOOD_COMMIT and BAD_COMMIT are set, then a behat bisect happens between the 2 commits, using the exact configuration provided (tags, name, browser, database, ...)
And, also, cover a couple of edge cases when options (normally --tags and --name) have white-spaces or ampersands.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 62.83% 63.90% +1.07%
==========================================
Files 38 38
Lines 1348 1402 +54
==========================================
+ Hits 847 896 +49
- Misses 501 506 +5 ☔ View full report in Codecov by Sentry. |
|
Self-merging this, so can launch some runs @ prod. Both local tests and GHA tell that we are ready! 🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If GOOD_COMMIT and BAD_COMMIT are set, then a behat bisect happens between the 2 commits, using the exact configuration provided (tags, name, browser, database, ...)
Also, fix some edge case, specially with
--tagsor--nameoptions, about better handle parameters having spaces or ampersands. Only when injecting the command into a shell script, not problem when executed inline (docker exec ...).Covered with tests.