-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs section about running in local dev environment #245
Conversation
Codecov Report
@@ Coverage Diff @@
## master #245 +/- ##
=========================================
Coverage 84.67% 84.67%
Complexity 694 694
=========================================
Files 74 74
Lines 2147 2147
=========================================
Hits 1818 1818
Misses 329 329 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi Ruslan, thanks for writing this. Regarding the PHAR usage, what I do it to put it (a hard-link, I think that there are still some problems with soft links) into all my moodle base directories (note that Moodle's That, also allows me to just update any of the phar files to current one and bump, all them become updated. In any case this is only a detail. The important point is that, having the phar in the moodle base directory makes things easier and you can run (from base dir):
Similarly, the
Of course, for both to work, they need to be executed from base directory. Or, alternatively, specify where the base directory is using So this works:
(maybe this is something we could try to improve, making moodle detection better, but that's another story) Anyway. TL;DR; For your consideration if 1) putting the phar in moodle base dir or 2) adding the binary to the $PATH are good enough to comment about them. Always making clear that, in order for any of them (phar or binary) to work, they must be executed from base dir (dirroot). Ciao :-) |
Other that that. I like the document. Surely if we start adding more and more details to it (say |
Thanks Eloy, I modified the docs slightly to keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks!
No description provided.