Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --exclude option in phpcs command #259

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

NoelDeMartin
Copy link
Contributor

@NoelDeMartin NoelDeMartin commented Dec 6, 2023

I've been trying to exclude some rules from a plugin using a .phpcs.xml file and I didn't manage to do it. But it was very easy using the exclude option. I think this would be a nice addition.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f783423) 85.15% compared to head (79c6925) 85.17%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #259      +/-   ##
============================================
+ Coverage     85.15%   85.17%   +0.01%     
- Complexity      717      718       +1     
============================================
  Files            75       75              
  Lines          2229     2232       +3     
============================================
+ Hits           1898     1901       +3     
  Misses          331      331              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stronk7
Copy link
Member

stronk7 commented Dec 6, 2023

Sold!

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you the little details commented, just tell me what are you going to do (ignore or add it) and I'll approve this.

Thanks!

src/Command/CodeCheckerCommand.php Outdated Show resolved Hide resolved
@stronk7 stronk7 merged commit 3d85518 into moodlehq:main Dec 14, 2023
17 checks passed
@stronk7
Copy link
Member

stronk7 commented Dec 14, 2023

Sold, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants