Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step for Behat faildump storing as GHA artifact. #291

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

kabalin
Copy link
Member

@kabalin kabalin commented Mar 16, 2024

Add GHA step to store Behat faildump as workflow artifact, so it can be inspected.

image

This step will be run only if Behat step failed (see if statement). It also configured not to produce warning if files are not found (the cause of Behat error might be not the actual test scenario). Name is derived from the job matrix, it needs to be unique per job when matrix is used (artifact upload will fail on name conflict if more than 1 job will fail on Behat)

Demo (simplified for speed):

More info on upload artifact: https://github.com/actions/upload-artifact

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.04%. Comparing base (7b22048) to head (5e7efd1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #291   +/-   ##
=========================================
  Coverage     88.04%   88.04%           
  Complexity      731      731           
=========================================
  Files            75       75           
  Lines          2234     2234           
=========================================
  Hits           1967     1967           
  Misses          267      267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stronk7 stronk7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😛

@stronk7 stronk7 added the enhancement New feature or request label Mar 16, 2024
@kabalin kabalin merged commit 144700a into moodlehq:main Mar 16, 2024
24 checks passed
@kabalin kabalin deleted the faildump branch March 16, 2024 19:10
@kabalin
Copy link
Member Author

kabalin commented Mar 18, 2024

BTW, kudos also go to @marinaglancy who suggested the similar idea for our internal GitLab jobs 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants