Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MSSQL #302

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

justusdieckmann
Copy link

Hey everyone,

this PR adds support for MSSQL (Fixes #92)

I tested it with our plugin tool_lifecycle here. The errors in the first commit are correct, since we used some MSSQL-incompatible syntax in the plugin. Those were addressed in the next two commits.

Justus

@justusdieckmann
Copy link
Author

Sadly, there is no good way around the need for a password for the database with the official docker image, so I passed that to moodle-plugin-ci install only if matrix.database == 'sqlsrv'.

I have not looked into the .travis.dist.yml yet, since I am much more familiar with github actions.

Also, in the gha.dist.yml, I have completely replaced the ${{ matrix.extensions }} with sqlsrv, since extensions wasn't set anywhere.

I would be glad for any comments and opinions! :)

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.25%. Comparing base (783ec09) to head (0ddd3c9).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/Installer/Database/MSSQLDatabase.php 93.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #302      +/-   ##
============================================
+ Coverage     88.22%   88.25%   +0.03%     
- Complexity      734      738       +4     
============================================
  Files            76       77       +1     
  Lines          2267     2282      +15     
============================================
+ Hits           2000     2014      +14     
- Misses          267      268       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: MSSQL support
1 participant