-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nvm 0.39.7 #310
Use nvm 0.39.7 #310
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
=========================================
Coverage 88.25% 88.25%
+ Complexity 739 737 -2
=========================================
Files 76 76
Lines 2274 2274
=========================================
Hits 2007 2007
Misses 267 267 ☔ View full report in Codecov by Sentry. |
…we swap to temporary workaround (moodlehq/moodle-plugin-ci#310)
This is to have control over image supplied version to prevent regression similar to moodlehq#309.
I suggest to install 0.39.7 explicitly as part of initialisation step, so we have control over the version we use. Also |
Closing in favour of #312 |
* Fix Syntax for moodle-plugin-ci: Provide path to plugin source as last argument * Temporary fix for CI moodlehq/moodle-plugin-ci#310
This is a temporary workaround for #309. Not sure if we need to make it permanent and advice changing workflows, depends on how quickly the issue will be fixed upstream.