Fixes for #124 and #126 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhunt
force-pushed
the
main
branch
4 times, most recently
from
ffa0d27
to
db17fc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #124 by bumping the PostgreSQL version for GitHub actions to 12, so the tests can run on 4.1 and above.
I have fixed #126 by having the custom behat step swap "CHR" for "CHAR" if you're on a MySQL-family database. This seemed the sensible place to do it rather than having 2 separate behat tests. The alternative would be to make the change when the query is saved or executed, meaning it would work when you actually use the plugin too, but I'd expect people will write the flavour of SQL for the database they're actually running on, and if they migrate it's not unreasonable to expect them to update their queries.